Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Include all audio priming packets if closest is start #10691

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

derrod
Copy link
Member

@derrod derrod commented May 18, 2024

Description

If the audio packet chosen for A/V sync is the start of the encoded bitstream also include all previous audio packets to ensure all "priming" samples are included.

Motivation and Context

Same as #10689 but will ensure that all priming samples for AAC are included (2 additional packets for CoreAudio, 1 additional packet for FFmpeg). This may however require some further testing and thought to ensure multi-track audio/video does not cause issues.

How Has This Been Tested?

Did some test recordings and looked at the results in Resolve.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added the Enhancement Improvement to existing functionality label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant