Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve yolov8 config #988

Merged
merged 5 commits into from
May 19, 2024
Merged

Improve yolov8 config #988

merged 5 commits into from
May 19, 2024

Conversation

GuillaumeBruand
Copy link
Contributor

@GuillaumeBruand GuillaumeBruand commented Jan 17, 2024

  • Allow user to pass custom yolo config through the standard yolo yaml config file
  • Pass the confidence threshold to inner model to avoid prefiltering with default yolo threshold=0.25

For yolov8, the predict configuration is given at inference time.
We can pass full parameters using the "cfg" argument and a yaml configuration file.

Passing the "conf" argument using confidence_threshold also avoids to prefilter boxes in the underlying yolo model.

Fixes #1030.

GuillaumeBruand and others added 2 commits January 17, 2024 18:50
- Allow user to pass custom yolo config through the standard yolo yaml config file
- Pass the confidence threshold to inner model to avoid prefiltering with default yolo threshold=0.25
@fcakyon
Copy link
Collaborator

fcakyon commented Apr 8, 2024

Amazing contribution @GuillaumeBruand ! 🚀

Please fix the errors raised in tests by:

  • Install required development packages:
pip install -e ."[dev]"
  • Reformat with black and isort:
python -m scripts.run_code_style format

Then commit+push

@fcakyon
Copy link
Collaborator

fcakyon commented May 19, 2024

Thanks for the amazing contribution @GuillaumeBruand !

@fcakyon fcakyon added the bug Something isn't working label May 19, 2024
@fcakyon fcakyon added this pull request to the merge queue May 19, 2024
Merged via the queue into obss:main with commit caac6e9 May 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants