Fixing vulkan buffer destruction while in use. #7380
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function CreateOrResizeBuffer destroys vulkan buffers and memory while they could be alive and in use by the GPU.
This can be captured if the validation layer is used. Moreover this could cause very hard to track low repro crashes.
This fix ensures the device is idle before freeing GPU resources. An alternative solution is to have fence-style syncrhonization and a destruction queue, however this might add further complexity and is likely overkill for imgui. Since buffer recreation is relatively a low frequency operation I suspect this is enough.
Tested: