Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agnoster): add anaconda env information #12434

Merged
merged 1 commit into from
May 21, 2024

Conversation

Ochoja
Copy link
Contributor

@Ochoja Ochoja commented May 21, 2024

Standards checklist:

  • [ x ] The PR title is descriptive.
  • [ x ] The PR doesn't replicate another PR which is already open.
  • [ x ] I have read the contribution guide and followed all the instructions.
  • [ x ] The code follows the code style guide detailed in the wiki.
  • [ x ] The code is mine or it's from somewhere with an MIT-compatible license.
  • [ x ] The code is efficient, to the best of my ability, and does not waste computer resources.
  • [ x ] The code is stable and I have tested it myself, to the best of my abilities.
  • [ x ] If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • [...]

Other comments:

...

@ohmyzsh ohmyzsh bot added the Area: theme Issue or PR related to a theme label May 21, 2024
@carlosala carlosala changed the title modified agnoster theme to support virtual environment using anaconda feat(agnoster): add anaconda env information May 21, 2024
@carlosala carlosala merged commit 309129f into ohmyzsh:master May 21, 2024
1 check passed
@carlosala
Copy link
Member

Thanks, great addition!

@mhart
Copy link

mhart commented May 22, 2024

Hmmm. This has suddenly made "base" appear in all of my prompts. Was it intended to be shown by default, even when on the "base" environment?

@@ -227,6 +227,14 @@ prompt_virtualenv() {
fi
}

# Conda Virtualenv
promp_conda_virtualenv() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: prompt_conda_virtualenv

@carlosala
Copy link
Member

Maybe we could skip base, sounds great

@carlosala
Copy link
Member

Could you make a PR?

@H-Cao
Copy link

H-Cao commented May 22, 2024

This change makes my shell prompt behave weirdly (the conda environment name appears twice). I tried to configure conda not to change PS1 in the hope that it would drop (base) at the front of the shell prompt. But the other one disappeared as well.

Is there any way to get around this? Or should I keep using the old theme config? Thanks!

EDIT: update screenshot
Screenshot 2024-05-21 at 23 24 09

carlosala added a commit that referenced this pull request May 22, 2024
@carlosala
Copy link
Member

I reverted the changes 👍🏻

gbastkowski pushed a commit to gbastkowski/oh-my-zsh that referenced this pull request May 28, 2024
gbastkowski pushed a commit to gbastkowski/oh-my-zsh that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: theme Issue or PR related to a theme
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants