-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8 new styles and "dark" and "light" updates #1882
base: master
Are you sure you want to change the base?
Conversation
Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks |
Yes, I do if you are still interested in merging the styles inside Olive |
I appreciate the effort, but I'm against merging this work into the main repository.
I would rather like to see the theming support to be extended on the code side so that additional themes don't require to compile Olive. Such themes can then be added to a community repo, easily downloaded and installed, without creating a maintenance burden. |
I do agree. BTW, by now it's the only path I can follow in order to add new styles
Here is where I don't agree (but I understand your position). Themes are what they are but they cover a pretty important aspect of UI-UX: they let customize the look so that users feel comfortable with their software and let them work lots of hours without feeling tired. The fact is that it's impossible to find a perfect theme that suits everybody and therefore the existence of themes... and that's why most (open) software offers the option to change and edit them.
And here is where our thoughts meet and the option that solves everything:
The only "disadvantage" is that, as you said, somebody needs to take care of these code changes. Once finished it would let users load custom themes just by placing the files into a specific folder and Olive on startup would read all of them and let users activate the desired one. I could always be extended with UI components to let users import-export them from Olive Preferences but that's not necessary. I hope you like the idea and feel like doing the needed code changes. From my side, I can provide these themes and more if you suggest it (for instance high-contrast, Protanopia, Deuteranopia, Tritanopia, ...) Cheers |
Since a while I have been working on Olive styles:
Following up a quick screenshot of all themes (including actual ones) so that makes it easy to discuss:
Dark (actual)
Dark (updated)
Darker
Grey
Light (actual)
Light (updated)
Olive
Resolve
Seasons - fall
Seasons - spring
Seasons - summer
Seasons - winter
Cheers