-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Socket scale using ip-hash algo #643
Open
subh-cs
wants to merge
10
commits into
openchatai:main
Choose a base branch
from
subh-cs:socket-scale
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the llm-server to scale horizontally by having multiple replicas. Fixes #625
The approach
For only socket connections nginx will remember the request ip and redirect all relevant response to the same ip.
Using Nginx
Warning:
If you wanna test this locally, you will notice that one server (eg. server1) is taking responsibility for multiple chatbots. This is because Nginx is remembering your ip-address and will redirect all socket request to server1. So even-if you're chatting with 100 chatbots in a same time from same ip-address, it will redirect all the requests to that one server.
Solution:
It should work in production because the request ip-addresses will be different for users and multiple server instances will come into picture.