Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add policy support to the chart #1094

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

Conversation

alexellis
Copy link
Member

Description

Add policy support to the chart

Why is this needed?

  • I have raised an issue to propose this change (required)

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

alexellis and others added 30 commits March 23, 2023 16:05
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The openid_url env variable was renamed to openid_issuer on the
oidc-plugin.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Add a ServiceAccount and ClusterRole required by the oics-plugin to
listen for changes on IAM objects.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
The goal of this commit is to simplify maintaining configurations
for Pro and CE for Prometheus.

Tested that either file was outputted via helm template with
the --show-only flag when toggling openfaasPro=true/false.

Tested e2e with CE - showing autoscaling with alert-manager
Tested e2e with Pro with Kind and hey, with autoscaling
taking place, and RAM/CPU, provider and function metrics
showing up.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
These are and always have been licensed code, and are not part
of OpenFaaS CE or OSS.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Alert manager is only used in OpenFaaS CE, remove it from the OpenFaaS
Pro deployment.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Allows users to select the secret with the signing keys or leave blank
to have the keys generated automatically by the dashboard.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
When the signing key is not given, then a new key is generated
every time the dashboard is updated or restarted.

This is useful for dev, but we recommend creating a secret
instead.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20220624214902-1bab6f366d9e to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/commits/v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
The plugin is no longer required because the logic has been
brought in-process for both the OpenFaaS CE and Pro gateway.

If you have the basic-auth-plugin deployment and service
left over in your cluster, you can safely delete them after
updating your gateway CE / Pro version to the latest.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
The OpenFaaS license was not mounted in the the autoscaler container
when basic auth is disabled in the chart. This prevented the autoscaler
from starting.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.1.0 to 3.5.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3.1.0...v3.5.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
A few users who haven't read the docs carefully enough were
trying to use OpenFaaS Pro scaling labels with the CE edition.

This improves the developer experience by showing them the
mistake, so they can fix it instead of raising an issue and
creating noise.

The docs cover both scaling approaches clearly along with
their labels.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Correct drift within limits available for community (hobbyist)
users.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Bumps openfaas/license-check from 0.4.1 to 0.4.2.

---
updated-dependencies:
- dependency-name: openfaas/license-check
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.5.0 to 4.0.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3.5.0...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot bot and others added 7 commits April 13, 2023 16:42
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v3...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 1 to 3.
- [Release notes](https://github.com/azure/setup-helm/releases)
- [Commits](Azure/setup-helm@v1...v3)

---
updated-dependencies:
- dependency-name: azure/setup-helm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
* pro-builder/buildkit are updated to resolve a security
issue with buildkit/containerd/runc - updating is advised

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants