Make a small change to the wording around requiring new releases #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
reviewed
Feb 20, 2024
| @@ -101,7 +101,7 @@ Pre-publication steps: | |||
| - Download the proof, check all references have DOIs, follow the links and check the references. | |||
| - EditorialBot can help check references with the command `@editorialbot check references` | |||
| - Proof-read the paper and ask authors to fix any remaining typos, badly formed citations, awkward wording, etc.. | |||
| - Ask the author to make a tagged release and archive, and report the version number and archive DOI in the review thread. | |||
| - Ask the author to make a tagged release and archive, and report the version number and archive DOI in the review thread. Note that a new release is only necessary if the software changed during the course of the review. In particular, changes to the paper do not require creating a new release. | |||
There was a problem hiding this comment.
I suggest to have each sentence on a new line as that improves the git diff down the line.
Suggested change
| - Ask the author to make a tagged release and archive, and report the version number and archive DOI in the review thread. Note that a new release is only necessary if the software changed during the course of the review. In particular, changes to the paper do not require creating a new release. | |
| - Ask the author to make a tagged release and archive, and report the version number and archive DOI in the review thread. | |
| Note that a new release is only necessary if the software changed during the course of the review. | |
| In particular, changes to the paper do not require creating a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally was initially confused about whether a new release was required if there were only changes to the paper, so I've hopefully clarified that a bit.