Clean up LOG/PRINT functions. Fixes #5004. #5006
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the error-log output next to the console output. (This means that error-log entries are suppressed after five identical ones. Is that good?)
Move throwing on hardwarning/error out of the
PRINT()
functions and into its own function, and have LOG() call that function. (Fixes #5004.)Along the way, clean up a little: nobody outside of printutils.cc should be calling
PRINT_NOCACHE()
, so scope it static. Remove PRINTB_NOCACHE since it's unused and its one pseudo-use in a comment looks like the intent is the same asPRINTD()
.