[GPU] Fix wrong condition for dynamic onednn convolution impl-type. #24497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the limitation for oneDNN convolution doesn't support dynmaic input and output. oneDNN opt convolution run blocked-format, so current SA convolution doesn't support in dpas flatform. Signed-off-by: hyunback <hyunback.kim@intel.com>
isanghao
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the limitation that oneDNN convolution doesn't support dynamic input and output.
With this limitation, clDNN convolution will run forever in dpas platform.
Because oneDNN Opt convolutions require blocked-format and current shape agnostic convolution doesn't support block-format, convolution do nothing in compile_graph stage and actual kernel compilation will happen at first inference.
Tickets: