Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding loop creation during replacement #24521

Closed
wants to merge 11 commits into from
Closed

Avoiding loop creation during replacement #24521

wants to merge 11 commits into from

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented May 15, 2024 •
edited

Details:

Avoiding the situation where a node's output becomes its input

Example:

unsqueezed_position_ids = opset13.unsqueeze(position_ids, opset13.constant(1))  # inject sequence dimension = 1
replace_node(position_ids, unsqueezed_position_ids)
position_ids = unsqueezed_position_ids

Tickets:

  • N/A

@itikhono itikhono requested a review from a team as a code owner May 15, 2024 08:45
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label May 15, 2024
@praasz praasz self-assigned this May 16, 2024
@itikhono itikhono requested a review from praasz May 16, 2024 08:22
@itikhono itikhono added this to the 2024.2 milestone May 16, 2024
@itikhono itikhono enabled auto-merge May 17, 2024 05:39
@itikhono itikhono disabled auto-merge May 20, 2024 15:29
@itikhono itikhono enabled auto-merge May 20, 2024 15:32
@itikhono
Copy link
Contributor Author

already merged as part of #24591

@itikhono itikhono closed this May 20, 2024
auto-merge was automatically disabled May 20, 2024 16:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@praasz praasz praasz approved these changes

Assignees

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itikhono @t-jankowski @praasz