[Snippets] United Static and Dynamic Loops into one node #24525
+377
−770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
a-sidorova
force-pushed
the
feature/snippets/dynamism/unite_loops
branch
2 times, most recently
from
d23fafe
to
6895d11
Compare
a-sidorova
force-pushed
the
feature/snippets/dynamism/unite_loops
branch
2 times, most recently
from
050f9ab
to
4d487e3
Compare
github-actions
bot
removed
the
category: IE Tests
a-sidorova
force-pushed
the
feature/snippets/dynamism/unite_loops
branch
from
4d487e3
to
3933dac
Compare
v-Golubev
reviewed
May 22, 2024
src/plugins/intel_cpu/src/emitters/snippets/x64/jit_loop_emitters.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/x64/jit_loop_emitters.cpp
Outdated
Show resolved
Hide resolved
1 task
v-Golubev
approved these changes
May 23, 2024
src/plugins/intel_cpu/src/emitters/snippets/x64/jit_loop_emitters.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/x64/jit_loop_emitters.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
feature/snippets/dynamism/unite_loops
branch
from
3ecf794
to
a963836
Compare
a-sidorova
force-pushed
the
feature/snippets/dynamism/unite_loops
branch
from
a963836
to
f5f86f2
Compare
|
@IvanNovoselov may I ask you to take a look at the changes please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
LoopEndStaticandLoopEndDynamicinto one nodeLoopEndto avoid extra conditions in the code and improve performance since some pointer data shifts might be known and compiled in JIT codeIdentifyBuffersandDefineBufferClusters. It's not efficient algorithm since we don't know exact values of data pointer shifts and cannot be sure that they will be proportionally in runtime. It should be implemented as the separate feature based on some judgments, for exampleTickets:
Prerequisites: