Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19872 : Responsiveness in the about section was inaccurate. #19887

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

rahat2134
Copy link
Contributor

@rahat2134 rahat2134 commented Mar 5, 2024

Overview

  1. This PR fixes or fixes part of [BUG]: The Access the android app button should be completely visible #19872 .
  2. This PR does the following: Responsiveness in the about section was inaccurate in access the android button specially. It was not visible at some widths. Resolve all those issues.

Essential Checklist

  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have followed the instructions for making a code change.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
  • The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

screen-capture.20.webm

PR Pointers

@rahat2134 rahat2134 requested a review from a team as a code owner March 5, 2024 21:08
@rahat2134 rahat2134 requested a review from Nik-09 March 5, 2024 21:08
@rahat2134 rahat2134 requested review from nikitaevg and removed request for Nik-09 March 5, 2024 21:09
@rahat2134
Copy link
Contributor Author

@nikitaevg PTAL.

Copy link

oppiabot bot commented Mar 5, 2024

Hi @rahat2134 please assign the required reviewer(s) for this PR. Thanks!

@rahat2134 rahat2134 closed this Mar 6, 2024
@rahat2134 rahat2134 reopened this Mar 6, 2024
@rahat2134
Copy link
Contributor Author

@nikitaevg PTAL.

@rahat2134 rahat2134 requested a review from Nik-09 March 7, 2024 09:56
@rahat2134
Copy link
Contributor Author

@Nik-09 PTAL untill @nikitaevg is back. I think he is busy.

@oppiabot oppiabot bot unassigned rahat2134 Mar 7, 2024
Copy link

oppiabot bot commented Mar 7, 2024

Unassigning @rahat2134 since a re-review was requested. @rahat2134, please make sure you have addressed all review comments. Thanks!

@nikitaevg nikitaevg removed the request for review from Nik-09 March 7, 2024 19:50
@nikitaevg
Copy link
Contributor

Hi @rahat2134

Please allow at least 2 days for reviewers to respond before pinging, let alone reassigning to others. Most people do this in their spare time, not every day

Copy link
Contributor

@nikitaevg nikitaevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good approach to fix the issue. Let's fix it properly. Why the padding or padding-top should be different for 960px, 868px, 698px etc? We have a simple task - the button should be within this container for all widths. Please find a solution that fixes the task without so many if-s, this is a too dirty solution.

@oppiabot oppiabot bot unassigned nikitaevg Mar 7, 2024
Copy link

oppiabot bot commented Mar 7, 2024

Unassigning @nikitaevg since the review is done.

Copy link

oppiabot bot commented Mar 7, 2024

Hi @rahat2134, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!

Copy link

oppiabot bot commented Mar 28, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Mar 28, 2024
@oppiabot oppiabot bot closed this Apr 1, 2024
@rahat2134 rahat2134 reopened this Apr 1, 2024
@oppiabot oppiabot bot removed the stale label Apr 1, 2024
Copy link

oppiabot bot commented Apr 10, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Apr 10, 2024
@oppiabot oppiabot bot removed the stale label Apr 12, 2024
Copy link

oppiabot bot commented Apr 19, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Apr 19, 2024
@oppiabot oppiabot bot removed the stale label Apr 19, 2024
@rahat2134 rahat2134 marked this pull request as draft April 24, 2024 11:21
Copy link

oppiabot bot commented May 8, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label May 8, 2024
@oppiabot oppiabot bot removed the stale label May 8, 2024
Copy link

oppiabot bot commented May 15, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label May 15, 2024
@oppiabot oppiabot bot removed the stale label May 15, 2024
Copy link

oppiabot bot commented May 22, 2024

Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label May 22, 2024
@oppiabot oppiabot bot removed the stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants