-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19872 : Responsiveness in the about section was inaccurate. #19887
base: develop
Are you sure you want to change the base?
Conversation
@nikitaevg PTAL. |
Hi @rahat2134 please assign the required reviewer(s) for this PR. Thanks! |
@nikitaevg PTAL. |
@Nik-09 PTAL untill @nikitaevg is back. I think he is busy. |
Unassigning @rahat2134 since a re-review was requested. @rahat2134, please make sure you have addressed all review comments. Thanks! |
Hi @rahat2134 Please allow at least 2 days for reviewers to respond before pinging, let alone reassigning to others. Most people do this in their spare time, not every day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good approach to fix the issue. Let's fix it properly. Why the padding or padding-top should be different for 960px, 868px, 698px etc? We have a simple task - the button should be within this container for all widths. Please find a solution that fixes the task without so many if-s, this is a too dirty solution.
Unassigning @nikitaevg since the review is done. |
Hi @rahat2134, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks! |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Hi @rahat2134, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
Overview
access the android
button specially. It was not visible at some widths. Resolve all those issues.Essential Checklist
Proof that changes are correct
screen-capture.20.webm
PR Pointers