-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to list pending etchings #3732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Definitely also needs an integration test. You could put that in the tests/wallet/resume.rs
file.
src/subcommand/wallet/pending.rs
Outdated
.pending_etchings()? | ||
.into_iter() | ||
.map(|(rune, entry)| { | ||
let spaced_rune = rune.to_string().parse::<SpacedRune>().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raphjaph what's the best way to get a SpacedRune
from a Rune
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's buried inside the entry struct. Something like this:
let spaced_rune = entry.output.rune.unwrap().rune
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs an integration test. You could put that in /tests/wallet/resume.rs
probably
src/subcommand/wallet/pending.rs
Outdated
.pending_etchings()? | ||
.into_iter() | ||
.map(|(rune, entry)| { | ||
let spaced_rune = rune.to_string().parse::<SpacedRune>().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's buried inside the entry struct. Something like this:
let spaced_rune = entry.output.rune.unwrap().rune
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Add a new
ord wallet pending
command to list pending etchings, as mentioned by @raphjaph on #3679.