Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decode api #3733

Merged
merged 6 commits into from
May 17, 2024
Merged

Add decode api #3733

merged 6 commits into from
May 17, 2024

Conversation

shadowv0vshadow
Copy link
Contributor

Based on the issue #3676, I have added an API named "decode" to parse the OP_RETURN in transactions (tx).

raphjaph
raphjaph requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Could you add a test in tests/json_api.rs?

@shadowv0vshadow
Copy link
Contributor Author

The decode/{txid}api reuses the code from the decode CLI, and the result is consistent with the CLI's result.

raphjaph
raphjaph approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) May 17, 2024 15:45
@raphjaph raphjaph merged commit 301f256 into ordinals:master May 17, 2024
5 checks passed
@raphjaph raphjaph mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowv0vshadow @raphjaph