-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
premine percentage and supply fields update for rune.html #3748
Conversation
presents options to fix ordinals#3630
Thanks for this intiative! Do you think your'd be able to add #3677? It goes well with this one. |
Hi HubertusVIE - the changes required for 3677 would be much, much more involved and I wouldn't even know where to begin. That change will need to be implemented by Casey and Raph because it involves upgrades to the protocol. This change that I've made only involves small updates to the rune webpage. They may seem like they go together nicely, but from a coding perspective, they are opposite ends of the spectrum. |
this is Greg's code to fix ordinals#3493 - I replicated the issue and verified that this fixed it on my local.
reverting changes for test troubleshooting
real revert to 0.18.5 rune.html
I've reverted these changes in order to better understand the test failures they're triggering. Still working on this, just need to reevaluate the best way to move forward. Renaming the supply field in the .html page causes over 90 tests to fail. |
I think doing these one at a time would be a good idea. So, for example, start with |
adding new field `mint progress` to rune.html to show the current supply of max supply ratio.
update batch function to account for new `mint_progress` field
added fn max_supply
added mint_progress to runes_are_displayed_on_rune_page test
added `mint_progress` to display test
bad indent
Thank you, Casey - I appreciate your guidance and patience. I've taken your advice and just added the |
Nice! I think mint progress should be expressed as a percentage with two digits after the decimal point. So it would be something like |
changing mint progress to percentage
changing `mint progress` to percentage
changing `mint progress` to percentage
changing `mint progress` to percentage
reverting previous changes; this file was accidentally included in this change.
changing `mint progress` to percentage
cargo fmt
how's this look to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying this PR, this is much easier to review!
LGTM
Another tip for follow-up PRs: It's always best to work on feature branches. Assuming you're on your First pull in the latest changes from the
Then create a local branch:
Then make you changes and do
Open a PR from that local branch which would have the name
Repeat this for every feature/PR and you'll have a good work flow :) |
Thanks for the tip, @raphjaph - I've been really struggling with figuring out that process and so that is immensely helpful for me. I was already able to use this process once successfully on a new PR I just submitted. @casey thank you again for your help on this. what would you recommend for the first additional follow up PR? I feel like the I hope memeing is supported on this platform. |
You bet! I'm not actually sure I would want to expose "premine percentage of maximum supply", because it might not correspond to anything meaningful. The maximum supply can be very high, but if it never actually mints out, then that percentage is a bit misleading. |
I see that point and agree. I feel the heart of the issue is when people would go to this mintable example rune page and see that the At the same time, going to an unmintable example rune page and seeing the I'm sure this is over complicating things, but it's almost as if there should be different stats for mintable vs unmintable/expired mint runes. Mintable runes could show current and maximum possible supply stats and percentages, to showcase the growth capability. Unmintable could have I'm sorry I'm not presenting any great solution suggestions, but this is the crux of what I think needs to be addressed. If there are no good ideas right now, we can park it for awhile and I will continue to noodle it. |
I do think it would be a good idea, once a rune is unmintable, to display the premine percentage as a percentage of the final supply. |
presents options to fix #3630
changes made:
mint progress
fieldrenamedsupply
tocurrent supply
addedmaximum supply
fieldaddedsupply progress
fieldrenamedpremine percentage
topremine percentage of current supply
addedpremine percentage of maximum supply
formula