-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delegate value to inscription endpoint #3751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small change
Co-authored-by: raph <raphjaph@protonmail.com>
@phorkish That "this branch is out-of-date with the base branch" means that your PR no longer merges cleanly to the upstream repo because something incompatible was merged. You need to merge your change to the master branch and push the change to your branch. It's kind of annoying to have to keep doing that, but someone needs to do it. |
There's a feature on GitHub which auto updates branches if they can be merged cleanly. I'll try to find it and activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to add the we should add this field to to docs. Could you add the delegate: None
field to the examples in the recursion.md
docs?
Yep, done. Sorry about missing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add the delegate ID to the
/inscription/[id]
endpoint. If there is no delegate then the response doesn't include that field.