Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegate value to inscription endpoint #3751

Merged
merged 7 commits into from
May 24, 2024

Conversation

phorkish
Copy link
Contributor

Add the delegate ID to the /inscription/[id] endpoint. If there is no delegate then the response doesn't include that field.

@cryptoni9n cryptoni9n requested a review from raphjaph May 17, 2024 19:27
@elocremarc
Copy link
Contributor

@gmart7t2 This PR is attempting the same thing as yours gonna link these together.
#3761

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small change

src/api.rs Outdated Show resolved Hide resolved
Co-authored-by: raph <raphjaph@protonmail.com>
@gmart7t2
Copy link
Contributor

@phorkish That "this branch is out-of-date with the base branch" means that your PR no longer merges cleanly to the upstream repo because something incompatible was merged. You need to merge your change to the master branch and push the change to your branch.

It's kind of annoying to have to keep doing that, but someone needs to do it.

@raphjaph
Copy link
Collaborator

@phorkish That "this branch is out-of-date with the base branch" means that your PR no longer merges cleanly to the upstream repo because something incompatible was merged. You need to merge your change to the master branch and push the change to your branch.

It's kind of annoying to have to keep doing that, but someone needs to do it.

There's a feature on GitHub which auto updates branches if they can be merged cleanly. I'll try to find it and activate

@raphjaph
Copy link
Collaborator

#3784

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to add the we should add this field to to docs. Could you add the delegate: None field to the examples in the recursion.md docs?

@phorkish
Copy link
Contributor Author

Yep, done. Sorry about missing that.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) May 24, 2024 16:38
@raphjaph raphjaph merged commit 7ba899a into ordinals:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants