-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feerate_percentiles to blockinfo endpoint #3753
Conversation
Why only the 10th percentile? We could consider allowing all of them. Just out of interest, what are you building with this? |
I am looking for the lowest fee that was included in a block and min_fee_rate seems unreliable. I will be using the low fee rate to trigger a dynamic inscription. I can add all 5 percentiles later today if you think it's worth doing all at once. |
As part of the strict backwards compatibility requirements for recursive endpoints we can only add fields, never remove or change an existing one. So I think adding all of them into one field makes sense here. |
@raphjaph ok I added feerate_percentiles, does this look correct to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Just a small docs addition needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small nit
Co-authored-by: raph <raphjaph@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add feerate_percentiles to blockinfo