Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD doesn't work #10725

Closed
mnpenner opened this issue May 1, 2024 · 1 comment · Fixed by #11078
Closed

BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD doesn't work #10725

mnpenner opened this issue May 1, 2024 · 1 comment · Fixed by #11078
Labels
bug Something isn't working

Comments

@mnpenner
Copy link

mnpenner commented May 1, 2024

What version of Bun is running?

1.1.6+e58d67b46

What platform is your computer?

Linux 4.4.0-19041-Microsoft x86_64 x86_64

What steps can reproduce the bug?

Run

BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD=1 bun run --watch server/index.ts

Then edit some code.

What is the expected behavior?

Bun does not clear the terminal on reload.

What do you see instead?

Bun clears the terminal on reload.

Additional information

https://bun.sh/docs/runtime/env says it should work.
@mnpenner mnpenner added the bug Something isn't working label May 1, 2024
@mnpenner
Copy link
Author

mnpenner commented May 7, 2024

I just figured it out by looking at the source code.

bun/src/bun.js/javascript.zig

Line 868 in 4970ffc

if (!strings.eqlComptime(this.bundler.env.get("BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD") orelse "0", "true")) {

The docs say 1 should work though:

image

I also just found #9647 to fix the docs.

@Jarred-Sumner Jarred-Sumner mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD env var oven-sh/bun
1 participant
@mnpenner