New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD` env var #11078

Merged

Jarred-Sumner merged 3 commits into main from jarred/no-config-clear-terminal

May 15, 2024

Collaborator

Jarred-Sumner commented May 14, 2024 •

edited

What does this PR do?

Fix BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD env var so that it handles more ways to say false. Any value which is not a falsy value makes it set to true, if it is set

For example:

BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD=123 bun --watch src/server.ts will disable clearing the screen
BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD=0 bun --watch src/server.ts will enable clearing the screen
BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD= bun --watch src/server.ts will enable clearing the screen

Fixes #10725

How did you verify your code works?

Did not test it.

Jarred-Sumner added 2 commits

May 14, 2024 15:38


          Fix BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD env var

1a177fb


          Make the existence of ansi colors set the default

62e058a

github-actions bot commented May 14, 2024 •

edited

❌ @Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

test/js/bun/http/serve.test.ts 2 failing

💻 2 failing tests Darwin x64 baseline

test/cli/install/registry/bun-install-registry.test.ts 2 failing
test/js/bun/http/serve.test.ts 1 failing

💻 2 failing tests Darwin x64

test/js/bun/http/serve.test.ts 1 failing
test/js/bun/test/test-test.test.ts 1 failing

🐧💪 1 failing tests Linux AARCH64

test/js/third_party/jsonwebtoken/noTimestamp.test.js 1 failing

🐧🖥 1 failing tests Linux x64 baseline

test/js/node/child_process/child_process-node.test.js 1 failing

🪟💻 7 failing tests Windows x64 baseline

test/cli/install/bunx.test.ts 4 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/process/process.test.js 2 failing

🪟💻 9 failing tests Windows x64

test/cli/install/bunx.test.ts 1 failing
test/cli/install/migration/migrate.test.ts 1 failing
test/cli/install/registry/bun-install-registry.test.ts SIGTERM
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/process/process.test.js 2 failing

Jarred-Sumner requested review from a team and zackradisic and removed request for a team

May 14, 2024 23:51


          Add --no-clear-screen flag

b27a9e3

Collaborator Author

Jarred-Sumner commented May 15, 2024

manually tested

Jarred-Sumner requested review from paperdave and removed request for zackradisic

May 15, 2024 00:50

paperdave approved these changes

View reviewed changes

Jarred-Sumner merged commit c4840f8 into main

45 of 52 checks passed

Jarred-Sumner deleted the jarred/no-config-clear-terminal branch

May 15, 2024 01:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment