feat: roundtrip pg_lakehouse test + fetch_recordbatch helper #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebasedming
reviewed
May 16, 2024
neilyio
force-pushed
the
neil/fetch-recordbatch
branch
4 times, most recently
from
c0785fb
to
860651a
Compare
neilyio
force-pushed
the
neil/fetch-recordbatch
branch
from
39bd943
to
90e5513
Compare
rebasedming
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a test for a "roundtrip" of creating a
RecordBatchin memory, storing in localstack s3, retrieving theRecordBatch, and comparing against original.Also made sure that the BYTEA type is supported by DataType::Binary.
Why
Testing as many supported datatypes as possible, and adding tooling to dynamically retrieve record batches in our test environment without having to manually specify the
RecordBatchschema.