Fix for updating record on pinecone #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ def update_texts(texts:, ids:, namespace: "", metadata: nil) | |||
| namespace: namespace, | |||
| id: ids[i].to_s, | |||
| values: llm.embed(text: text).embedding, | |||
| set_metadata: metadata | |||
| set_metadata: metadata || {content: text} | |||
There was a problem hiding this comment.
Can we optionally pass metadata if it's set? Otherwise not even pass this parameter. Would that work for your usecase?
There was a problem hiding this comment.
Yes, that works for me, it's not required for my use case, but I followed the format in add_texts in case it was needed. The metadata is only convenient to identify the vector entries when browsing from pinecone db directly, but is not functionally necessary.
|
@ddyy Specs are broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a record with pinecone db, I receive this error:
NoMethodError: undefined method `empty?' for nil:NilClass (NoMethodError)
/ruby-3.2.2/gems/pinecone-0.1.71/lib/pinecone/vector.rb:51:in
update' /ruby-3.2.2/gems/langchainrb-0.8.2/lib/langchain/vectorsearch/pinecone.rb:91:inblock in update_texts'This PR fixes the missing metadata by setting it the same way in update_data as it's set in add_data