Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gameSize equal to baseSize, for EXPAND scale mode #6818

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

rexrainbow
Copy link
Contributor

Please do not update the README or Change Log, we will do this when we merge your PR.

This PR (delete as applicable)

  • Fixes a bug

Describe the changes below:

gameSize is used for world bounds, cameras, set gameSize equal to baseSize, so that camera can render on whole game window.

@rexrainbow rexrainbow changed the title Set gameSize equal to baseSize Set gameSize equal to baseSize, for EXPAND scale mode May 16, 2024
@philipgriffin
Copy link

Should scale/index.js be updated too? (as it is not referenced in the docs due to not being added here)

@rexrainbow
Copy link
Contributor Author

Should scale/index.js be updated too? (as it is not referenced in the docs due to not being added here)

Thanks, I had exposed EXPAND in index.js file in latest commit.

@photonstorm photonstorm merged commit 228736a into phaserjs:master Jun 6, 2024
@photonstorm
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants