v2.4 #199
v2.4 #199
Conversation
ashpreetbedi
commented
Apr 29, 2024
•
ashpreetbedi
commented
- Remove LLM Task
- Add Async Run
- Add Messages Param
- Add Workflows
phi/assistant/assistant.py
Outdated
| # | ||
| # -*- List of messages added to the messages list after the system prompt. | ||
| # Use these for few-shot learning or to provide additional context to the LLM. | ||
| add_messages: Optional[List[Union[Dict, Message]]] = None |
There was a problem hiding this comment.
This feels a bit confusing for me. Could be additional_messages instead? add_messages feel like a method for adding messages to a list.
There was a problem hiding this comment.
@sandangel agree, will update it to be additional_messages
There was a problem hiding this comment.
@sandangel looking for a better name for this param :/
| def streamable(self) -> bool: | ||
| return self.output_model is None |
There was a problem hiding this comment.
Maybe with llama-index integration, we can stream partial intermediate pydantic object?
There was a problem hiding this comment.
@sandangel this is on the list for us to implement :) maybe i hack on it tonight :)
|
For |
cookbook/assistants/add_messages.py
Outdated
| Assistant( | ||
| llm=OpenAIChat(model="gpt-3.5-turbo", stop="</answer>"), | ||
| system_prompt="What is the color of a banana? Provide your answer in the xml tag <answer>.", | ||
| add_messages=[{"role": "assistant", "content": "<answer>"}], |
There was a problem hiding this comment.
| add_messages=[{"role": "assistant", "content": "<answer>"}], | |
| additional_messages=[{"role": "assistant", "content": "<answer>"}], |
Maybe a mypy type check would catch this bug.
|
Is there a design document we can share for the |
cookbook/workflows/hackernews.py
Outdated
| tools=[get_user_details], | ||
| show_tool_calls=True, | ||
| ) | ||
|
|
||
| hn_assistant = Assistant(name="HackerNews Assistant", team=[hn_top_stories, hn_user_researcher], debug_mode=True) | ||
| hn_assistant.print_response("Tell me about the users with the top 2 stores on hackernews?", markdown=True) | ||
| hn_team = Workflow( |
There was a problem hiding this comment.
| hn_team = Workflow( | |
| hn_workflow = Workflow( |
