Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ticdc): Add more test cases #11068

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented May 10, 2024

What problem does this PR solve?

Issue Number: ref #10781

What is changed and how it works?

  1. add integration test check after resign ticdc owner

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.2586%. Comparing base (be15534) to head (30361e5).
Report is 32 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.6017% <ø> (+0.8417%) ⬆️
dm 52.2297% <ø> (+1.0002%) ⬆️
engine 63.4585% <ø> (+0.0564%) ⬆️
Flag Coverage Δ
unit 58.2586% <ø> (+0.8258%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11068        +/-   ##
================================================
+ Coverage   57.4327%   58.2586%   +0.8258%     
================================================
  Files           851        854         +3     
  Lines        125230     128139      +2909     
================================================
+ Hits          71923      74652      +2729     
- Misses        47914      48039       +125     
- Partials       5393       5448        +55     

@sdojjy
Copy link
Member Author

sdojjy commented May 10, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented May 17, 2024

/retest-required

Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-17 06:20:44.020944052 +0000 UTC m=+1806997.778079710: ☑️ agreed by 3AceShowHand.
  • 2024-05-17 06:25:03.527190755 +0000 UTC m=+1807257.284326327: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented May 23, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 5ef14cb into pingcap:master May 23, 2024
28 checks passed
@sdojjy sdojjy deleted the add-test-cases branch May 23, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants