Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public Framebuffer.depth and Framebuffer.stencil properties #9338

Open
wants to merge 3 commits into
base: v7.x
Choose a base branch
from

Conversation

dev7355608
Copy link
Collaborator

Description of change

I thought it might be useful if these properties are publicly accessible and can be changed with the framebuffer automatically updating.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@dev7355608 dev7355608 marked this pull request as ready for review April 4, 2023 14:49
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bigtimebuddy bigtimebuddy added this to the v7.3.0 milestone Apr 4, 2023
@bigtimebuddy bigtimebuddy removed this from the v7.3.0 milestone Apr 19, 2023
@GoodBoyDigital
Copy link
Member

Hey @dev7355608 ! This is certainly a technically correct PR, but i can't think of a use case where this would be useful :D
We would prefer users to make separate FB's rather than changing these on the fly I think?

@dev7355608
Copy link
Collaborator Author

Yeah, probably unlikely that these properties are changed, but I thought why not: it can't really hurt to have it.

@bigtimebuddy bigtimebuddy added the 🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. label May 24, 2023
@talented634
Copy link

Nice

1 similar comment
@talented634
Copy link

Nice

@Zyie Zyie deleted the branch v7.x March 5, 2024 17:16
@Zyie Zyie closed this Mar 5, 2024
@Zyie Zyie reopened this Mar 5, 2024
@Zyie Zyie changed the base branch from dev to v7.x March 5, 2024 18:07
@Zyie Zyie added the v7 label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. v7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants