Fix the timeseries for the 7d period with hour interval #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
ruslandoga
reviewed
Sep 22, 2023
ruslandoga
reviewed
Sep 22, 2023
test/plausible_web/controllers/api/stats_controller/main_graph_test.exs
Outdated
Show resolved
Hide resolved
krisbuist
force-pushed
the
fix-7d-hour-main-graph
branch
from
0b4d92f
to
8f4d61b
Compare
krisbuist
force-pushed
the
fix-7d-hour-main-graph
branch
from
8f4d61b
to
0cd61b1
Compare
|
I'm wondering if this is actually a relevant fix or that the previous behaviour was intentional. |
When bucketing on hour, the current day needs to be taken into account for as well. The query executed on the database already contained the correct results, but they were omitted because too few buckets were selected
krisbuist
force-pushed
the
fix-7d-hour-main-graph
branch
from
0cd61b1
to
711c468
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bucketing on hour, the current day needs to be taken into account for as well. The query executed on the database already contained the correct results, but they were omitted because too few buckets were selected
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests
Changelog
Documentation
Dark mode