Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external link in pages details modal #3585

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Maskoe
Copy link

@Maskoe Maskoe commented Dec 2, 2023

Changes

image

I noticed the details pages modal does not let me navigate to the external link like the dashboard top pages section lets me do.
So I added it to the modal too.

The code is mostly taken from "assets/js/dashboard/stats/reports/list.js" and minimally adjusted.
This guy noticed it too. https://feedback.plausible.io/267

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants