Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save search events #1373

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Save search events #1373

wants to merge 3 commits into from

Conversation

SilasMarvin
Copy link
Contributor

No description provided.

@SilasMarvin SilasMarvin changed the title Prep for saving events Save search events Mar 15, 2024
@SilasMarvin SilasMarvin marked this pull request as draft March 15, 2024 16:23
@SilasMarvin SilasMarvin marked this pull request as ready for review March 15, 2024 20:19
chillenberger
chillenberger approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@chillenberger chillenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where we are catching the info from the blog search selection. The blog search uses different js than the site search since at the time it needed to trigger on a button click not typing, but that is changing.

@SilasMarvin
Copy link
Contributor Author

SilasMarvin commented Mar 15, 2024 •
edited

I don't see where we are catching the info from the blog search selection. The blog search uses different js than the site search since at the time it needed to trigger on a button click not typing, but that is changing.

Good call. Just added it! 8918309

@SilasMarvin SilasMarvin reopened this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillenberger chillenberger chillenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SilasMarvin @chillenberger