Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6416: Health Check Additions #6468

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

anirudhkovuru
Copy link
Contributor

Change log description
This is a continuation of #6430.

Purpose of the change
Fixes #6416.

What the code does
This can be found in #6430. Any updates to the existing design will be duly updated.

How to verify it
All tests must pass.

Signed-off-by: anirudhkovuru <anirudhkovuru@gmail.com>
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #6468 (e98d7d8) into master (3c34d6b) will increase coverage by 0.00%.
The diff coverage is 83.03%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6468   +/-   ##
=========================================
  Coverage     86.22%   86.23%           
- Complexity    15448    15455    +7     
=========================================
  Files          1009     1014    +5     
  Lines         57926    57999   +73     
  Branches       5914     5913    -1     
=========================================
+ Hits          49949    50017   +68     
- Misses         4894     4896    +2     
- Partials       3083     3086    +3     
Impacted Files Coverage Δ
...avega/controller/server/ControllerServiceMain.java 81.73% <ø> (ø)
.../pravega/segmentstore/server/SegmentContainer.java 100.00% <ø> (ø)
...reamSegmentContainerMetadataHealthContributor.java 33.33% <33.33%> (ø)
...a/segmentstore/server/logs/OperationProcessor.java 87.41% <36.36%> (-1.32%) ⬇️
...ver/containers/StreamSegmentContainerMetadata.java 96.87% <66.66%> (+0.05%) ⬆️
...java/io/pravega/shared/health/HealthConnector.java 66.66% <66.66%> (ø)
...avega/segmentstore/server/host/ServiceStarter.java 68.44% <71.42%> (-0.20%) ⬇️
.../health/contributors/ServiceHealthContributor.java 72.72% <72.72%> (ø)
...erver/logs/health/DurableLogHealthContributor.java 75.00% <75.00%> (ø)
...rver/logs/health/InMemoryLogHealthContributor.java 83.33% <75.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c34d6b...e98d7d8. Read the comment docs.

@RaulGracia
Copy link
Contributor

@anirudhkovuru I think that there are comments of mine in #6430 that are unaddressed. If you want to continue with this PR, I recommend you to revisit the comments of that PR to see what were the comments and what is left to address before doing another round of review.

Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be comments unaddressed from last review in original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Health Check Additions
3 participants