Azure Bindings: Resolving IllegalArgumentException when parsing storage custom config parameters #6876
Conversation
Codecov ReportBase: 86.45% // Head: 86.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6876 +/- ##
============================================
+ Coverage 86.45% 86.47% +0.02%
+ Complexity 16066 16060 -6
============================================
Files 1039 1038 -1
Lines 59922 59878 -44
Branches 6064 6057 -7
============================================
- Hits 51803 51779 -24
+ Misses 4938 4929 -9
+ Partials 3181 3170 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
AJadhav29
force-pushed
the
azure_config
branch
from
59045f2
to
70671c6
Compare
Signed-off-by: Aditi Jadhav <Aditi.Jadhav@dell.com> Signed-off-by: Aditi Jadhav <Aditi.Jadhav@dell.com>
Signed-off-by: Aditi Jadhav <Aditi.Jadhav@dell.com>
Signed-off-by: Aditi Jadhav <Aditi.Jadhav@dell.com>
Signed-off-by: Aditi Jadhav <Aditi.Jadhav@dell.com>
RaulGracia
requested review from
sachin-j-joshi,
RaulGracia,
abhinb and
kuldeepk3
| @@ -240,19 +240,27 @@ private Map<String, Object> getTier2Env() { | |||
| return parseSystemPropertyAsMap("tier2Env"); | |||
| } | |||
|
|
|||
| private Map<String, Object> parseSystemPropertyAsMap(String systemProperty) { | |||
| public static Map<String, Object> parseSystemPropertyAsMap(String systemProperty) { | |||
There was a problem hiding this comment.
If this is just for testing, this could have package visibility instead of public, right?
| } | ||
|
|
||
| @NonNull | ||
| public static Map<String, Object> parseSystemPropertyAsMap(String systemProperty, String value) { |
There was a problem hiding this comment.
This is completely changing the behavior of this method, right? Previously, it was returning a map in which all values were Integer, and now it is putting some string in the value. How is this impacting the configuration of system tests? Are system tests working and configured as expected with this change?
Change log description
Resolving IllegalArgumentException when parsing config parameters in a String.
Purpose of the change
Fixes #6875
What the code does
The code splits the custom config parsed as String ("," separated) appropriately into the config parameter and it's value.
It then stores them in the form of key-value pairs and returns the resulting map.
How to verify it
All the tests should pass.