Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6905: LTS - Correctly pass executor to CompletableFuture Async calls. #6906

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sachin-j-joshi
Copy link
Contributor

Signed-off-by: Sachin Joshi sachin.joshi@emc.com

Change log description
Issue 6905: LTS - Correctly pass executor to CompletableFuture.composeAsync calls.

Purpose of the change
Fixes #6905

What the code does
Correctly pass executor to CompletableFuture.composeAsync calls.

How to verify it
All tests should pass

…calls.

Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 86.34% // Head: 86.33% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1591eed) compared to base (e69687f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1591eed differs from pull request most recent head 011dafe. Consider uploading reports for the commit 011dafe to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6906      +/-   ##
============================================
- Coverage     86.34%   86.33%   -0.01%     
+ Complexity    15917    15910       -7     
============================================
  Files          1027     1027              
  Lines         59330    59273      -57     
  Branches       6001     5997       -4     
============================================
- Hits          51231    51176      -55     
- Misses         4958     4959       +1     
+ Partials       3141     3138       -3     
Impacted Files Coverage Δ
...erver/tables/FixedKeyLengthTableSegmentLayout.java 82.32% <100.00%> (ø)
...ain/java/io/pravega/client/stream/impl/Pinger.java 94.82% <0.00%> (-3.45%) ⬇️
...ntstore/storage/impl/bookkeeper/BookKeeperLog.java 83.03% <0.00%> (-3.09%) ⬇️
...a/segmentstore/server/logs/MemoryStateUpdater.java 76.47% <0.00%> (-2.36%) ⬇️
...orage/impl/bookkeeper/BookKeeperServiceRunner.java 70.62% <0.00%> (-2.15%) ⬇️
.../segmentstore/storage/impl/bookkeeper/Ledgers.java 78.21% <0.00%> (-1.99%) ⬇️
...egmentstore/server/reading/ContainerReadIndex.java 87.50% <0.00%> (-1.09%) ⬇️
...o/pravega/client/stream/impl/ReaderGroupState.java 93.49% <0.00%> (-0.91%) ⬇️
...ga/client/connection/impl/TcpClientConnection.java 89.11% <0.00%> (-0.69%) ⬇️
...ver/containers/StreamSegmentContainerMetadata.java 96.81% <0.00%> (-0.64%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sachin-j-joshi sachin-j-joshi marked this pull request as draft October 6, 2022 20:47
Copy link
Contributor

@RaulGracia RaulGracia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the coverage check is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly pass executor to CompletableFuture Async calls.
3 participants