Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue durable log throttle #7038

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

shshashwat
Copy link
Contributor

Change log description
(2-3 concise points about the changes in this PR. When committing this PR, the committer is expected to copy the content of this section to the merge description box)

Purpose of the change
(e.g., Fixes #666, Closes #1234)

What the code does
(Detailed description of the code changes)

How to verify it
(Optional: steps to verify that the changes are effective)

sachin-j-joshi and others added 7 commits March 27, 2023 15:38
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com>
Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com>
Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com>
Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 96.96% and no project coverage change.

Comparison is base (798d8a2) 86.35% compared to head (2c2921c) 86.35%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7038   +/-   ##
=========================================
  Coverage     86.35%   86.35%           
- Complexity    16047    16056    +9     
=========================================
  Files          1031     1031           
  Lines         59815    59847   +32     
  Branches       6071     6076    +5     
=========================================
+ Hits          51653    51682   +29     
- Misses         4988     4989    +1     
- Partials       3174     3176    +2     
Impacted Files Coverage Δ
...io/pravega/segmentstore/server/logs/Throttler.java 92.30% <ø> (ø)
.../segmentstore/server/logs/ThrottlerCalculator.java 96.22% <96.77%> (+0.17%) ⬆️
...a/segmentstore/server/logs/OperationProcessor.java 89.86% <100.00%> (-0.67%) ⬇️
...io/pravega/segmentstore/storage/WriteSettings.java 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for RocksDBCache
2 participants