[prometheus-ipmi-exporter] Optionally pull config from a Secret #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Jones <nick@dischord.org>
zeritti
requested changes
May 23, 2024
There was a problem hiding this comment.
Thank you, @yankcrime, for your PR. Please, see my comments below.
| @@ -1,4 +1,4 @@ | |||
| {{- if not .Values.configMapFile -}} | |||
There was a problem hiding this comment.
The field configMapFile does not occur elsewhere in the chart, I reckon its purpose was somehow not implemented and can therefore safely be removed.
| @@ -1,4 +1,4 @@ | |||
| {{- if not .Values.configMapFile -}} | |||
| {{- if not .Values.useSecret -}} | |||
There was a problem hiding this comment.
I'd suggest a differently named toggle (more below):
Suggested change
| {{- if not .Values.useSecret -}} | |
| {{- if not .Values.configSecret.enabled -}} |
Comment on lines
+59
to
+65
| {{- if .Values.useSecret }} | ||
| secret: | ||
| secretName: {{ .Values.secret.name }} | ||
| items: | ||
| - key: {{ .Values.secret.key }} | ||
| path: config.yml | ||
| {{- else }} |
There was a problem hiding this comment.
With respect to the comment above:
Suggested change
| {{- if .Values.useSecret }} | |
| secret: | |
| secretName: {{ .Values.secret.name }} | |
| items: | |
| - key: {{ .Values.secret.key }} | |
| path: config.yml | |
| {{- else }} | |
| {{- if .Values.configSecret.enabled }} | |
| secret: | |
| secretName: {{ .Values.configSecret.name }} | |
| items: | |
| - key: {{ .Values.configSecret.key }} | |
| path: config.yml | |
| {{- else }} |
Comment on lines
+66
to
+69
| useSecret: false | ||
| secret: | ||
| name: ipmi-secret | ||
| key: config.yml |
There was a problem hiding this comment.
We should be a bit more specific of the secret. If using a map for a single feature, I'd suggest putting the toggle in the map.
Suggested change
| useSecret: false | |
| secret: | |
| name: ipmi-secret | |
| key: config.yml | |
| configSecret: | |
| enabled: false | |
| name: ipmi-secret | |
| key: config.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The way this currently works is that it builds a config file from values inlined via Helm, and this may need to include some sensitive information such as usernames and passwords that should be otherwise kept out of a repo in the cases where you're managing all of your cluster configuration via git.
This PR update the Chart to add an option to be able to reference a Secret instead.
Checklist
[prometheus-couchdb-exporter])