Fix torchchat model not working on demo apps #3668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3668
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit d0750b2 with merge base 16a892d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
May 18, 2024
|
Thank you @larryliu0820 Validated. Works with torchchat exported model and tokenizer.bin. |
Summary: As titled Test Plan: Use torchchat to export llama3 pte file, run it in executorch, see it running Reviewers: Subscribers: Tasks: Tags:
larryliu0820
force-pushed
the
fix_demo_app
branch
from
c4d41d2
to
d0750b2
Compare
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@larryliu0820 merged this pull request in 75dcaa6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled fix https://github.com/pytorch/torchchat/issues/810
Test Plan: Use torchchat to export llama3 pte file, run it in executorch, see it running
Reviewers:
Subscribers:
Tasks:
Tags: