Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aoti] Add support for more custom op input/output types #126215

Open
wants to merge 5 commits into
base: gh/angelayi/52/base
Choose a base branch
from

Conversation

Copy link

pytorch-bot bot commented May 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126215

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 03456a8 with merge base ff82e2e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

angelayi added a commit that referenced this pull request May 14, 2024
ghstack-source-id: ccda8ac4f6705364b0384cc83b60d63030a6269d
Pull Request resolved: #126215
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
angelayi added a commit that referenced this pull request May 15, 2024
ghstack-source-id: b7b60e382e48cbc4f3b84980fb09532d2b598d72
Pull Request resolved: #126215
@@ -140,7 +452,10 @@ OSSProxyExecutor::OSSProxyExecutor(const std::string& json_path, bool is_cpu) {
json_file >> json_obj;

// Access data
std::cout << json_obj["nodes"] << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these couts for debugging or logging? If they are for logging, could we use c10's logging utilities?

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
angelayi added a commit that referenced this pull request May 15, 2024
ghstack-source-id: de48af5238a267cd6fbae48d9dc192ee9470cfd1
Pull Request resolved: #126215
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
angelayi added a commit that referenced this pull request May 15, 2024
ghstack-source-id: f9641b6d711449d371a453e8bbaf6ae91f30f898
Pull Request resolved: #126215
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
angelayi added a commit that referenced this pull request May 23, 2024
ghstack-source-id: d323c99b587ba653406f37837fb43ed0a4fed632
Pull Request resolved: #126215
switch (scalarType) {
case 0: // ScalarType.UNKNOWN
TORCH_CHECK(false, "Unknown scalar type");
case 1: // ScalarType.BYTE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure this kind of enum value mapping is always valid, to avoid any surprising BC breakage. I think this is achieved by defining a Thrift mapping internally (or maybe even that doesn't provide a strong guard on BC, cc @SherlockNoMad ). Because this kind of enum value should rarely change in practice, we could add some enum value checking at the compile time to make sure the mapping hasn't changed. Or maybe simply adding more tests to test/cpp/aoti_abi_check to prevent surprising enum value changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants