[pipelining] Follow improvements in export.unflatten #126217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126217
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c75e69b with merge base 3759676 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kwen2501
added a commit
that referenced
this pull request
May 14, 2024
ghstack-source-id: ae40df3b4575acbf2f35039db6891ed1478d0619 Pull Request resolved: #126217
H-Huang
approved these changes
May 17, 2024
| assert node_module_stack == self.module_stack | ||
| self.copy_node(node) | ||
| node_idx += 1 | ||
| from torch.export.unflatten import _ModuleFrame | ||
|
|
||
|
|
||
| def _outline_submodules(orig_graph: torch.fx.Graph): |
There was a problem hiding this comment.
Any value of this just getting moved to torch.export.unflatten as well? Or is this pretty PP specific?
There was a problem hiding this comment.
yeah, this is the one func that's special.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Previously, we make a copy of `torch.export.unflatten` in pippy/_unflatten.py. But it turns out to be too hard to track bug fixes and improvements in upstream version. For example, `torch.export.unflatten` recently added support for tied parameters, which is something pipelining needs. Now that we moved into pytorch, we make a reference to `torch.export.unflatten` instead of maintaining a copy. Pull Request resolved: pytorch#126217 Approved by: https://github.com/H-Huang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we make a copy of
torch.export.unflattenin pippy/_unflatten.py.But it turns out to be too hard to track bug fixes and improvements in upstream version. For example,
torch.export.unflattenrecently added support for tied parameters, which is something pipelining needs.Now that we moved into pytorch, we make a reference to
torch.export.unflatteninstead of maintaining a copy.Stack from ghstack (oldest at bottom):
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k