Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamo] SizeVariable supports hasattr #126222

Closed
wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

@yanboliang yanboliang commented May 14, 2024

Copy link

pytorch-bot bot commented May 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126222

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0938004 with merge base c312cd8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label May 14, 2024
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be wrong for named tuples.
Can you add a test with named tuple where the field is present? I think it will incorrectly return False.

@yanboliang
Copy link
Contributor Author

@anijain2305 NamedTuple has been fixed at #124531

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aplologize. For some reason, I thought NamedTupleVariable is a subclass of SizeVariable. My bad. This is good.

@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the size-hasattr branch May 15, 2024 17:19
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants