[checkpointing] import async checkpoint with pinned memory only when needed #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needed [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
May 15, 2024
…needed ghstack-source-id: e460a8d6458f191f7f589fc908974f896b514690 Pull Request resolved: #333
facebook-github-bot
added
the
CLA Signed
Closed
fegin
approved these changes
May 15, 2024
tianyu-l
added a commit
that referenced
this pull request
May 15, 2024
…needed ghstack-source-id: e460a8d6458f191f7f589fc908974f896b514690 Pull Request resolved: #333
tianyu-l
added a commit
that referenced
this pull request
May 28, 2024
…needed ghstack-source-id: e460a8d6458f191f7f589fc908974f896b514690 Pull Request resolved: #333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
"Async checkpointing with pinned memory" requires a very recent pytorch nightly. Since we don't want to fix a nightly in
requirements.txt, and this checkpointing option is not the default one, let's not import it under all circumstances.