feat: Introduce top-k algo to HNSW #4114
Conversation
lib/common/common/src/top_k.rs
Outdated
| @@ -11,7 +11,7 @@ use crate::types::{ScoreType, ScoredPointOffset}; | |||
| #[derive(Default)] | |||
| pub struct TopK { | |||
| k: usize, | |||
| elements: Vec<Reverse<ScoredPointOffset>>, | |||
| pub elements: Vec<Reverse<ScoredPointOffset>>, | |||
There was a problem hiding this comment.
I would prefer not to expose this.
You can either return reference to a slice in a method, or deconstruct the whole thing into vector if you need ownership
KShivendu
force-pushed
the
feat/hnsw-topk
branch
from
3436510
to
0203d07
Compare
* feat: Allow building any branch with GH dev image builder workflow * fix: Trim feat, fix, etc * fix: Replace all / with -
| None => true, | ||
| Some(removed) => removed.idx != score_point.idx, | ||
| }; | ||
| let was_added = self.nearest.push(score_point); |
There was a problem hiding this comment.
why is the deduplication based on removed.idx != score_point.idx, not required anymore?
There was a problem hiding this comment.
We can't return index of the point if it was discarded or not, because we would need to return a whole list in this case. So the TopK return type is different and it is just bool
| None => ScoreType::min_value(), | ||
| Some(worst_of_the_best) => worst_of_the_best.score, | ||
| } | ||
| self.nearest.threshold() |
There was a problem hiding this comment.
Why is it Ok. to use threshold here given that it is lazy and might not represent the full information of the top values?
There was a problem hiding this comment.
This might be not Ok, it is up to benchmarks
|
It doesn't look like the change gives us a benefit: Even though the TopK might improve candidate selection performance, it looks like the change in search_context update logic have more negative effect on overall results |
|
We see small gains (<10%) in latency with lower dims datasets like glove-100 but it also costs us some precision. So we decided to not merge this.
|
|
I seems this PR is not longer neeeded. Closing it |
HNSW equivalent of #4037 PR.
New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Todo: