Add shard transfer method for resharding #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
force-pushed
the
resharding-shard-transfer
branch
from
a9426ed
to
db75345
Compare
timvisee
force-pushed
the
resharding-shard-transfer
branch
3 times, most recently
from
e839c63
to
285b117
Compare
timvisee
force-pushed
the
resharding-shard-transfer
branch
from
285b117
to
19b32ff
Compare
|
@ffuugoo I believe all the necessary bits have been implemented. If you think this is sufficient, I'd suggest to merge and polish this further down the line as necessary. |
ffuugoo
requested changes
May 22, 2024
Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
ffuugoo
approved these changes
May 22, 2024
generall
pushed a commit
that referenced
this pull request
May 26, 2024
* Add stubs for new shard transfer method used in resharding * Set correct shard replica set state when doing resharding transfer * Only transfer migrated points on resharding transfer * Use new resharding type, more convenient moved points check * Allow to specify different target shard for shard transfers * Add strict validation to target shard field, only different shard for resharding * Simplify if-condition * While doing resharding transfer, take the hashring only once * Hide resharding transfer method by default * On resharding transfer validation, the shards must have the same key * Restructure shard transfer validation logic * Use correct shard key in resharding transfer * Update shard transfer validation documentation * Share transfer batch size constant * Update lib/collection/src/hash_ring.rs Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com> * Use correct shard IDs when driving shard transfer --------- Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #4213
Adds a
ReshardingStreamRecordsshard transfer method that will be utilized as part of resharding.Tasks
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?