Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-query: Connect grpc internal query service #4223

Merged
merged 3 commits into from
May 15, 2024
Merged

universal-query: Connect grpc internal query service #4223

merged 3 commits into from
May 15, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented May 13, 2024 •
edited

  • Adds internal grpc -> ShardQueryRequest conversions
  • Sketches the points internal service handling (needs to wait until we add internal shard queries to TableOfContent)

@coszio coszio mentioned this pull request May 13, 2024
Open
29 tasks
@coszio coszio force-pushed the universal-query-at-shard-ops branch from 2368ae5 to 9680232 Compare May 14, 2024 15:43
@coszio coszio force-pushed the connect-grpc-internal-query-service branch from 230884c to 9541579 Compare May 14, 2024 20:14
@coszio coszio mentioned this pull request May 14, 2024
Merged
3 tasks
Base automatically changed from universal-query-at-shard-ops to dev May 15, 2024 13:36
@coszio coszio force-pushed the connect-grpc-internal-query-service branch from 9541579 to fb7072c Compare May 15, 2024 13:39
coszio
coszio commented May 15, 2024
View reviewed changes
lib/collection/src/operations/universal_query.rs
Comment on lines +452 to +463
}
} else {
let sources = recurse_prefetches(core_searches, prefetches);

let prefetch_plan = PrefetchPlan {
sources,
merge: PrefetchMerge {
rescore: Some(query),
limit,
},
};
PrefetchSource::Prefetch(prefetch_plan)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ShardQueryRequest -> PlannedQuery conversion is not important right now, it will be complete in #4242

@coszio coszio requested review from agourlay and timvisee May 15, 2024 13:47
@coszio coszio marked this pull request as ready for review May 15, 2024 13:47
@coszio coszio merged commit 4fd5df9 into dev May 15, 2024
17 checks passed
@coszio coszio deleted the connect-grpc-internal-query-service branch May 15, 2024 15:53
generall pushed a commit that referenced this pull request May 26, 2024
@coszio @generall
universal-query: Connect grpc internal query service (#4223)
d7186e8 
* add grpc -> internal conversions

* return `Status` instead of `CollectionError` in grpc -> internal conversions

* sketch points internal api connection of `query`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agourlay agourlay agourlay approved these changes

@timvisee timvisee Awaiting requested review from timvisee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coszio @agourlay