Float16 integration and API #4234
Conversation
There was a problem hiding this comment.
Cosine metric was missed, added
There was a problem hiding this comment.
Does preprocess work for non float32? I can add tests / SIMD implementations for cosine metric if helpful.
| Distance::Manhattan => <ManhattanMetric as Metric<VectorElementType>>::preprocess(v), | ||
| }; | ||
| Cow::from(preprocessed_vector) | ||
| Cow::Owned(vector.iter().map(|&x| f16::to_f32(x)).collect_vec()) |
There was a problem hiding this comment.
It was an incorrect implementation. quantization_preprocess is a trick for byte type, where we need to apply -127 for binary quantization. Here we need conversion into f32 only
| VectorStorageDatatype::Float16, | ||
| 64, | ||
| 20 | ||
| )] | ||
| fn test_byte_storage_hnsw( |
There was a problem hiding this comment.
I extended existing test for byte vector to test HNSW
| @@ -166,6 +194,7 @@ fn sames_count(a: &[Vec<ScoredPointOffset>], b: &[Vec<ScoredPointOffset>]) -> us | |||
| )] | |||
| fn test_byte_storage_binary_quantization_hnsw( | |||
| #[case] query_variant: QueryVariant, | |||
| #[case] storage_data_type: VectorStorageDatatype, | |||
There was a problem hiding this comment.
I extended existing test for byte vector to test quantization
| @@ -46,40 +48,68 @@ enum QuantizationVariant { | |||
| Binary, | |||
| } | |||
|
|
|||
| fn random_discovery_query<R: Rng + ?Sized>(rnd: &mut R, dim: usize) -> QueryVector { | |||
| fn random_vector<R>(rnd_gen: &mut R, dim: usize, data_type: VectorStorageDatatype) -> DenseVector | |||
There was a problem hiding this comment.
because we test binary quantization, we need to specify vector to utilize binary condition. for u8 we generate vectors in range [0; 255], for f16 we generate vectors in range [-0.5; 0.5]
tests api fix test are you happy clippy
IvanPleshkov
force-pushed
the
f16-integration
branch
from
c129559
to
b014ed2
Compare
* f16 integration tests api fix test are you happy clippy * fix build
Float16 REST and Grpc, storages, scorers, and constructors
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: