Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StartResharding operation to update_collection_cluster REST API #4239

Merged
merged 3 commits into from
May 17, 2024

Conversation

ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented May 14, 2024

Tracked in #4213.

This PR adds StartResharding operation to update_collection_cluster REST API.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo mentioned this pull request May 14, 2024
38 tasks
@ffuugoo ffuugoo force-pushed the add-start-resharding-consensus-message branch 2 times, most recently from b99daf7 to 9452435 Compare May 16, 2024 09:14
@ffuugoo ffuugoo requested review from timvisee and generall May 16, 2024 09:15
@ffuugoo ffuugoo marked this pull request as ready for review May 16, 2024 09:16
@ffuugoo ffuugoo force-pushed the add-start-resharding-api branch 2 times, most recently from 1d8bddd to e39346c Compare May 17, 2024 10:20
@timvisee timvisee force-pushed the add-start-resharding-consensus-message branch from a04ddd8 to 9cdb02d Compare May 17, 2024 11:51
Base automatically changed from add-start-resharding-consensus-message to dev May 17, 2024 14:58
@ffuugoo
Copy link
Contributor Author

ffuugoo commented May 17, 2024

Rebased on dev. This is ready for final review, I think. StartResharding operation is not yet exposed in the OpenAPI spec (just in case we will cut a release before finalizing resharding).

@ffuugoo ffuugoo merged commit 1fc43ee into dev May 17, 2024
17 checks passed
@ffuugoo ffuugoo deleted the add-start-resharding-api branch May 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants