universal-query: Add OrderBy scoring, and add scrolls to PlannedQuery
#4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
reviewed
May 18, 2024
| @@ -241,7 +241,7 @@ message QueryShardPoints { | |||
| oneof score { | |||
| RawQuery vector = 1; // (re)score against a vector query | |||
| bool rrf = 2; // Reciprocal Rank Fusion | |||
There was a problem hiding this comment.
Not related to this PR, but it might be better to use
enum Fusion {
RRF
}
instead of boolean?
There was a problem hiding this comment.
I considered that but I thought it would be too much nesting. I wasn't aware if the other fusion techniques are configurable
There was a problem hiding this comment.
booleans are much harder to extend
generall
approved these changes
May 18, 2024
generall
pushed a commit
that referenced
this pull request
May 26, 2024
* add `OrderBy` scoring, and add `scrolls` to `PlannedQuery`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in #4225
ScoringQuery::OrderByvariantPlannedQueryto also store a list of scroll alongside the core search batchQueryShardPointsalso gets the order-by variant