Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Always record original default values #40660

Merged
merged 1 commit into from
May 17, 2024

Conversation

radcortez
Copy link
Member

No description provided.

@gsmet
Copy link
Member

gsmet commented May 15, 2024

@radcortez so the problem wasn't that it didn't apply cleanly, the problem is I had a test failure:

See this comment: #40634 (comment)

@quarkus-bot

This comment has been minimized.

@radcortez
Copy link
Member Author

Ah, never mind. I misunderstood. I thought you meant you had a conflict in the code. Let me have a look.

@radcortez
Copy link
Member Author

The SR Config update to 3.8 does not require this fix, but since Quarkus 3.10 is still on SR Config 3.7, we also need to fix it for mappings defaults.

@quarkus-bot
Copy link

quarkus-bot bot commented May 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0b17dd6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections - History

  • Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.websockets.next.test.utils.WSClient.waitForMessages(WSClient.java:102)
	at io.quarkus.websockets.next.test.openconnections.OpenConnectionsTest.testOpenConnections(OpenConnectionsTest.java:69)

@gsmet gsmet changed the title [3.10] 3.10.1 backports 3 [3.10] Always record original default values May 17, 2024
@gsmet gsmet merged commit a45c652 into quarkusio:3.10 May 17, 2024
51 checks passed
@gsmet gsmet added this to the 3.10.2 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants