Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update toolbar when selection was lost #3231

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ArneBab
Copy link

@ArneBab ArneBab commented Nov 19, 2020

This fixes an issue in Chromium and Chrome: When the toolbar size selection is opened, the selection of the text is lost and the size selection does not show the currently selected size.

In Icecat (Firefox 78) the text selection is not lost upon opening the size selection, therefore the issue does not appear.

The change here causes the menu to keep the highlighting of the size of the currently selected text.

It does not cause the selection to persist.

@ArneBab
Copy link
Author

ArneBab commented Nov 19, 2020

The issue this fixes can be reproduced in the interactive playground: https://quilljs.com/playground/

It happens in Chromium

Select some text

quill-chromium-select-text

Open the size selection menu entry: It does not show the current size and the text in the text field is no longer selected

quill-chromium-select-text-open-menu

The list of sizes shows the highlight of the current size for a moment, then it flickers and the highlighting of the current size is gone along with the selection of the text.

But not in Icecat (Firefox)

Open the size selection menu entry: the current size is highlighted in blue and the selection in the text field persists

quill-icecat-ff78-select-text-open-menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant