Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(c): remove redundant newline and fix $0 position in main snippents #451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(c): remove redundant newline and fix $0 position in main snippents #451

wants to merge 2 commits into from

Conversation

REmerald
Copy link
Contributor

Kind of reverts 7a57697 and #443

The main point of not putting $0 on newly indented line is because it's way easier for a user to press enter than pressing esc then dd if inserting if with empty {} was intended. See #237 (comment).

OkelleyDevelopment
OkelleyDevelopment approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@OkelleyDevelopment OkelleyDevelopment left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but perhaps we can bring in some others so we're all on the same page since it's reverting some changes.

Will wait to merge, so others can view them as well.

cc: @ilan-schemoul @rafamadriz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OkelleyDevelopment OkelleyDevelopment OkelleyDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@REmerald @OkelleyDevelopment