Change BatchEnumerator#destroy_all to return the total number of affected rows
#51788
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
batch_enumerator-destroy_all-returns-rows-number
branch
from
5f7a63b
to
211c6bd
Compare
kamipo
reviewed
May 13, 2024
| # | ||
| # Person.where("age < 10").in_batches.destroy_all | ||
| # | ||
| # See Relation#destroy_all for details of how each batch is destroyed. | ||
| def destroy_all | ||
| each(&:destroy_all) | ||
| sum do |relation| | ||
| relation.destroy_all.size |
There was a problem hiding this comment.
If what we want is the total number of rows "affected", we should count destroyed records, since destroy_all returns matched records whether a record is destroyed or not. ref #37782 (comment)
Suggested change
| relation.destroy_all.size | |
| relation.destroy_all.count(&:destroyed?) |
There was a problem hiding this comment.
You are right, thanks! Also updated the test case to account for this.
fatkodima
force-pushed
the
batch_enumerator-destroy_all-returns-rows-number
branch
from
211c6bd
to
94af7c1
Compare
kamipo
added a commit
that referenced
this pull request
May 14, 2024
…-returns-rows-number Change `BatchEnumerator#destroy_all` to return the total number of affected rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ActiveRecord::Relation.destroy_allreturns all the affected records, so users can implement some custom logic based on that without querying the database prior to thedestroy_allcall.But,
in_batches.destroy_allalways returnsnil, which is not very much useful. And in this case, to implement some custom logic based on the affected rows, we actually need to query the database prior to the operation.This PR changes that method to always return the number of destroyed records.