New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change asset pipeline default to Propshaft in Rails 8 #51799
base: main
Are you sure you want to change the base?
Conversation
Lots of tests broken, but once we fix them, we can merge this. main is already Rails 8 |
railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
Outdated
Show resolved
Hide resolved
@@ -75,7 +75,7 @@ def self.add_shared_options_for(name) | |||
|
|||
class_option :skip_asset_pipeline, type: :boolean, aliases: "-A", default: nil | |||
|
|||
class_option :asset_pipeline, type: :string, aliases: "-a", default: "sprockets", | |||
class_option :asset_pipeline, type: :string, aliases: "-a", default: "propshaft", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be done in a follow-up PR, but are there documentation changes that we'd like to do as well?
… tests against sprockets too)
There's a fair amount of work in switching all the tests that assume sprockets over. If anyone is interested in helping with this transition, I'd love some assistance, while I tune up Propshaft with the other stuff we're missing before a release. |
I'd very much like to help with the transition. I'm not an expert, just an enthusiast. If you think it's something I could help with, I gladly offer my assistance 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
Sprockets has served us well, but it's time to hand over the torch to Propshaft in Rails 8.